rok commented on code in PR #49718:
URL: https://github.com/apache/arrow/pull/49718#discussion_r3078465704
##########
cpp/src/arrow/extension/fixed_shape_tensor.cc:
##########
@@ -119,29 +120,61 @@ Result<std::shared_ptr<DataType>>
FixedShapeTensorType::Deserialize(
}
std::vector<int64_t> shape;
- for (auto& x : document["shape"].GetArray()) {
+ for (const auto& x : document["shape"].GetArray()) {
+ if (!x.IsInt64()) {
+ return Status::Invalid("shape must contain integers");
Review Comment:
Changed. Now we emit value and type of the value on deserialization failure.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
