EmilyMatt commented on code in PR #9700:
URL: https://github.com/apache/arrow-rs/pull/9700#discussion_r3085685088
##########
parquet/src/data_type.rs:
##########
@@ -803,6 +801,10 @@ pub(crate) mod private {
Ok(values_read)
}
+ fn dict_encoding_size(&self) -> usize {
Review Comment:
Yeah this probably needs an unreachable!()
Though I believe a main principle is that this project should be really low
in the dependency graph, which merits not using panics, maybe a const here as
well will be fine, or 0, but I fear this may cause a never-ending
block/row-group if this assumption ever changes(for example, encoding a
full-true group or something.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
