etseidl commented on code in PR #9700: URL: https://github.com/apache/arrow-rs/pull/9700#discussion_r3081373645
########## parquet/src/encodings/encoding/plain_counter.rs: ########## @@ -0,0 +1,75 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agreements. See the NOTICE file +// distributed with this work for additional information +// regarding copyright ownership. The ASF licenses this file +// to you under the Apache License, Version 2.0 (the +// "License"); you may not use this file except in compliance +// with the License. You may obtain a copy of the License at +// +// http://www.apache.org/licenses/LICENSE-2.0 +// +// Unless required by applicable law or agreed to in writing, +// software distributed under the License is distributed on an +// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +// KIND, either express or implied. See the License for the +// specific language governing permissions and limitations +// under the License. + +use crate::basic::Type; +use crate::data_type::private::ParquetValueType; +use crate::schema::types::ColumnDescriptor; + +/// A helper to estimate the size of plain encoding of the values +/// that were written to the dictionary encoder. +/// +/// This is used to enhance the dictionary fallback heuristic with the logic +/// that the writer should fall back to the plain encoding when at a certain point, +/// e.g. after encoding the first batch, the total size of unencoded data +/// is calculated as smaller than `(encodedSize + dictionarySize)`. +pub struct PlainDataSizeCounter { Review Comment: Perhaps just values entered to cover lists as well. I think as long as there are a sufficient number of samples with which to make a decision, this could be quite nice in the end. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
