alamb commented on code in PR #9729: URL: https://github.com/apache/arrow-rs/pull/9729#discussion_r3094472064
########## arrow-cast/benches/cast_decimals.rs: ########## @@ -0,0 +1,346 @@ +// Licensed to the Apache Software Foundation (ASF) under one Review Comment: Sorry I missed this in a previous review, but I think the other benchmarks for cast are in the `cast_kernels.rs` benchmark: https://github.com/apache/arrow-rs/blob/main/arrow/benches/cast_kernels.rs Can we please add these benchmarks to the existing benchmark (e.g. https://github.com/apache/arrow-rs/blob/c5fed03500bfd332a5cf2e6e2f1df66aafe996f5/arrow/benches/cast_kernels.rs#L283-L324)? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
