klion26 commented on code in PR #9729:
URL: https://github.com/apache/arrow-rs/pull/9729#discussion_r3117046540


##########
arrow/benches/cast_kernels.rs:
##########
@@ -189,17 +268,24 @@ fn add_benchmark(c: &mut Criterion) {
     let utf8_date_array = build_utf8_date_array(512, true);
     let utf8_date_time_array = build_utf8_date_time_array(512, true);
 
-    let decimal32_array = build_decimal32_array(512, 9, 3);
-    let decimal64_array = build_decimal64_array(512, 10, 3);
-    let decimal128_array = build_decimal128_array(512, 10, 3);
-    let decimal256_array = build_decimal256_array(512, 50, 3);
+    let decimal32_array = build_decimal32_array(8_000, 9, 3);
+    let decimal64_array = build_decimal64_array(8_000, 10, 3);
+    let decimal128_array = build_decimal128_array(8_000, 10, 3);
+    let decimal256_array = build_decimal256_array(8_000, 50, 3);
     let string_array = build_string_array(512);
     let wide_string_array = cast(&string_array, &DataType::LargeUtf8).unwrap();
 
     let dict_array = build_dict_array(10_000);
     let string_view_array = cast(&dict_array, &DataType::Utf8View).unwrap();
     let binary_view_array = cast(&string_view_array, 
&DataType::BinaryView).unwrap();
 
+    let string_float_array_normal = build_string_float_array(5_000, 0.1);

Review Comment:
   The length set to 5000 because if I set this to 8000/6000, benchmark will 
show 
   `Warning: Unable to complete 100 samples in 5.0s. You may wish to increase 
target time to 6.0s, enable flat sampling, or reduce sample count to 60.)`



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to