Reranko05 commented on PR #49748: URL: https://github.com/apache/arrow/pull/49748#issuecomment-4266057864
Hi @kou, I ran a quick benchmark comparing the previous implementation and this change. Results (200 iterations): Small (~100B): - Before: ~0 ms - After: ~0 ms Medium (~10KB): - Before: 58 ms - After: 12 ms Large (~1MB): - Before: 4302 ms - After: 1126 ms The improvement is negligible for very small inputs but becomes significant as input size grows. This aligns with expectations, since the change replaces repeated linear `std::string::find` lookups with constant-time table access per character. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
