dmitry-chirkov-dremio commented on code in PR #49748: URL: https://github.com/apache/arrow/pull/49748#discussion_r3102930068
########## cpp/src/arrow/vendored/base64.cpp: ########## Review Comment: LGTM however I'd swap `string` for either of these: - `constexpr std::string_view base64_chars = "...";` - `constexpr auto base64_chars = "...";` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
