asubiotto commented on code in PR #9621:
URL: https://github.com/apache/arrow-rs/pull/9621#discussion_r3098602130
##########
arrow-ord/src/cmp.rs:
##########
@@ -340,29 +357,51 @@ fn compare_op(op: Op, lhs: &dyn Datum, rhs: &dyn Datum)
-> Result<BooleanArray,
})
}
+/// Per-side metadata for a comparison operand.
+struct SideInfo<'a> {
+ is_scalar: bool,
+ dict: Option<&'a dyn AnyDictionaryArray>,
+ ree: Option<&'a ReeInfo<'a>>,
+}
+
+impl SideInfo<'_> {
+ fn has_indirection(&self) -> bool {
+ self.dict.is_some() || self.ree.is_some()
+ }
+}
+
/// Perform a potentially vectored `op` on the provided `ArrayOrd`
fn apply<T: ArrayOrd>(
op: Op,
l: T,
- l_s: bool,
- l_v: Option<&dyn AnyDictionaryArray>,
+ l_info: &SideInfo,
r: T,
- r_s: bool,
- r_v: Option<&dyn AnyDictionaryArray>,
+ r_info: &SideInfo,
) -> Option<BooleanBuffer> {
if l.len() == 0 || r.len() == 0 {
return None; // Handle empty dictionaries
}
- if !l_s && !r_s && (l_v.is_some() || r_v.is_some()) {
- // Not scalar and at least one side has a dictionary, need to perform
vectored comparison
- let l_v = l_v
- .map(|x| x.normalized_keys())
- .unwrap_or_else(|| (0..l.len()).collect());
+ if !l_info.is_scalar
+ && !r_info.is_scalar
+ && (l_info.has_indirection() || r_info.has_indirection())
+ {
+ // Both non-scalar with indirection. Pure REE-vs-REE uses segment-based
+ // bulk comparison; other combinations fall back to index vectors.
+ if let (Some(li), None, Some(ri), None) = (l_info.ree, l_info.dict,
r_info.ree, r_info.dict)
Review Comment:
Done.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
