asubiotto commented on code in PR #9621:
URL: https://github.com/apache/arrow-rs/pull/9621#discussion_r3098684002
##########
arrow-ord/src/cmp.rs:
##########
@@ -257,18 +263,29 @@ fn compare_op(op: Op, lhs: &dyn Datum, rhs: &dyn Datum)
-> Result<BooleanArray,
)));
}
+ let l_side = SideInfo {
Review Comment:
Possibly but I'm not sure this will make the code clearer. As currently
written, `SideInfo` can be constructed only once before type the type dispatch.
I do think we could probably clean up this code as a whole though but would
need to think more deeply about how. I can create an issue but I don't like
doing so if there isn't a clear actionable item.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
