CurtHagenlocher opened a new pull request, #4243:
URL: https://github.com/apache/arrow-adbc/pull/4243
Adds net10.0 to the target frameworks for Apache.Arrow.Adbc and the
trace-listener assembly, with <IsAotCompatible>true</IsAotCompatible> enabled
on that TFM.
- Replace FileVersionInfo.GetVersionInfo(assembly.Location) with
AssemblyInformationalVersionAttribute lookup; Assembly.Location is empty under
single-file publish. A guarded FileVersionInfo fallback is retained for JIT via
RuntimeFeature.IsDynamicCodeSupported.
- Rewrite IArrowArrayExtensions.SerializeToJson to dispatch through
Utf8JsonWriter instead of the reflection-based JsonSerializer. Every value type
ParseStructArray can produce is dispatched explicitly. SqlDecimal (Decimal128)
now emits as a JSON number when the declared precision is <= 15 and as a string
otherwise, replacing the previous accidental {IsNull, Value, Precision, ...}
shape.
- Rewrite FileListener.ActivityProcessor to serialize via a source-
generated JsonSerializerContext. A new OtelAttributesConverter preserves
OpenTelemetry-compatible attribute values (string, bool, int64, double, and
homogeneous arrays) as native JSON; non-OTel values fall back to
invariant-culture strings so the output doesn't drift by locale.
- CAdbcDriverExporter.AdbcDriverInit returns NotImplemented rather than
InternalError for unsupported ADBC versions so the importer's 1.1.0 -> 1.0.0
fallback works.
- Add InternalsVisibleTo for Apache.Arrow.Adbc.Testing (the actual
assembly name; the existing Apache.Arrow.Adbc.Tests entry is stale).
Covered by 27 new golden-output tests for SerializeToJson and 14 new tests
for OtelAttributesConverter (including invariant-culture verification under a
non-English locale).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
