CurtHagenlocher commented on code in PR #4243:
URL: https://github.com/apache/arrow-adbc/pull/4243#discussion_r3106912552
##########
.github/workflows/csharp.yml:
##########
@@ -68,3 +68,51 @@ jobs:
- name: Test
shell: bash
run: ci/scripts/csharp_test.sh $(pwd)
+
+ # TODO: Create a test fixture driver to use for interop testing as the
+ # real drivers have migrated to https://github.com/adbc-drivers
+
+ # Publishes the Apache driver as a NativeAOT shared library (net10) and
+ # loads it from Python via adbc_driver_manager to catch AOT regressions
+ # (trim-unsafe reflection, missing exports, broken C-ABI marshaling).
+ # Windows-only for now; the smoke test only exercises Windows paths.
+ csharp-aot:
+ name: "C# NativeAOT smoke test (windows-2022)"
+ runs-on: windows-2022
+ # if: ${{ !contains(github.event.pull_request.title, 'WIP') }}
+ if: false
+ timeout-minutes: 30
+ steps:
+ - name: Checkout ADBC
+ uses: actions/checkout@v6
+ with:
+ fetch-depth: 0
+ submodules: recursive
+ - name: Install .NET 10
+ uses: actions/setup-dotnet@v5
+ with:
+ # NativeAOT for our producer requires net10. Using 10.0.x selects
+ # the latest available SDK; preview tags may be needed until GA.
+ dotnet-version: '10.0.x'
+ - name: Setup MSVC (for NativeAOT linker)
+ # Third-party action; activates vcvars64 so ilc's downstream
+ # link.exe step can find link.exe/lib.exe and the Windows SDK.
+ # The existing workflow only uses first-party actions, so flag
+ # this for review before enabling.
+ uses: ilammy/msvc-dev-cmd@0b201ec74fa43914dc39ae48a89fd1d8cb592756 #
v1
Review Comment:
Seems to be fairly widely used and hasn't been changed in a while. (This was
a Claude suggestion.)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
