sahuagin commented on code in PR #9787:
URL: https://github.com/apache/arrow-rs/pull/9787#discussion_r3124944845
##########
parquet/src/encodings/decoding.rs:
##########
@@ -847,6 +847,30 @@ where
self.values_left -= 1;
}
+ // Terminal skip: caller is discarding all remaining values on this
page.
+ // last_value will never be read again, so we can use O(1) arithmetic
+ // skips (BitReader::skip) instead of decoding through get_batch.
+ let terminal = to_skip >= self.values_left + skip;
+
+ if terminal {
+ while skip < to_skip {
Review Comment:
I have some concerns changing the tests to match my code: I'll call them out
specifically in my changes to make sure they are the ones that you were
thinking of.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
