etseidl commented on PR #9787: URL: https://github.com/apache/arrow-rs/pull/9787#issuecomment-4299909821
As a test, I replaced the contents of `skip_terminal` with a `panic`. The benchmarks ran to completion, so clearly `skip_terminal` is not being called. Also, neither the benchmarks run here nor those I've run locally show any measurable improvement using the terminal skip introduced in this PR. Thanks for the effort, but I don't think there is any win to be had here. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
