pitrou commented on code in PR #49756:
URL: https://github.com/apache/arrow/pull/49756#discussion_r3129619860
##########
cpp/src/arrow/util/bpacking.cc:
##########
@@ -52,12 +65,14 @@ struct UnpackDynamicFunction {
template <typename Uint>
void unpack(const uint8_t* in, Uint* out, const UnpackOptions& opts) {
-#if defined(ARROW_HAVE_NEON)
- return bpacking::unpack_neon(in, out, opts);
-#else
- static DynamicDispatch<UnpackDynamicFunction<Uint> > dispatch;
- return dispatch.func(in, out, opts);
-#endif
+ auto constexpr kImplementations =
UnpackDynamicFunction<Uint>::implementations();
+ if constexpr (kImplementations.size() == 1) {
Review Comment:
> Actually done in [GH-49840](https://github.com/apache/arrow/pull/49840) so
either way here
That PR might prove difficult to adapt for all the lousy compilers we have
to support, so I'd rather focus on this one first :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
