AntoinePrv commented on code in PR #49756:
URL: https://github.com/apache/arrow/pull/49756#discussion_r3122553088


##########
cpp/src/arrow/util/bpacking_simd_internal.h:
##########
@@ -25,68 +25,90 @@
 namespace arrow::internal::bpacking {
 
 #if defined(ARROW_HAVE_NEON)
+#  define UNPACK_ARCH128 unpack_neon
+#elif defined(ARROW_HAVE_SSE4_2)
+#  define UNPACK_ARCH128 unpack_sse4_2
+#endif

Review Comment:
   The issue is we need the file compiled twice in ARM (Neon + sve128).
   I think it is not possible directly in CMake. The solution is copy to build 
tree then compile each with different flags.
   Is a CMake-only solution satisfactory?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to