Dandandan commented on pull request #280:
URL: https://github.com/apache/arrow-datafusion/pull/280#issuecomment-834805975


   > I don't really understand the concerns about column expressions and what 
might be bad here. The alternate is probably to keep a "name" field on all 
`Exprs` which was the approach in 
[apache/arrow#9600](https://github.com/apache/arrow/pull/9600)
   
   Happy to reconsider! My main concern is that introducing aliases for unnamed 
expressions will cause other "strange" issues like using the name of the 
expression, like:
   `select "1+1" from (select 1+1) t`
   
   Which should fail but would return 2?
   
   I think we should make sure unnamed expressions can only be referenced by 
index, or with `*` and not by a generated name.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to