alamb commented on pull request #280: URL: https://github.com/apache/arrow-datafusion/pull/280#issuecomment-835267036
That makes sense, thank you for the clarification On Fri, May 7, 2021 at 5:53 PM Daniël Heres ***@***.***> wrote: > I don't really understand the concerns about column expressions and what > might be bad here. The alternate is probably to keep a "name" field on all > Exprs which was the approach in apache/arrow#9600 > <https://github.com/apache/arrow/pull/9600> > > Happy to reconsider! My main concern is that introducing aliases for > unnamed expressions will cause other "strange" issues like using the name > of the expression, like: > select "1+1" from (select 1+1) t > > Which should fail but would return 2? > > I think we should make sure unnamed expressions can only be referenced by > index, or with * and not by a generated name. > > — > You are receiving this because your review was requested. > Reply to this email directly, view it on GitHub > <https://github.com/apache/arrow-datafusion/pull/280#issuecomment-834805975>, > or unsubscribe > <https://github.com/notifications/unsubscribe-auth/AADXZMJ5SN5I2FDE3TBHR2TTMRON7ANCNFSM44H4TNUA> > . > -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
