Copilot commented on code in PR #49851: URL: https://github.com/apache/arrow/pull/49851#discussion_r3166720753
########## cpp/src/arrow/flight/sql/odbc/connection-options.md: ########## @@ -0,0 +1,64 @@ +<!--- + Licensed to the Apache Software Foundation (ASF) under one + or more contributor license agreements. See the NOTICE file + distributed with this work for additional information + regarding copyright ownership. The ASF licenses this file + to you under the Apache License, Version 2.0 (the + "License"); you may not use this file except in compliance + with the License. You may obtain a copy of the License at + + http://www.apache.org/licenses/LICENSE-2.0 + + Unless required by applicable law or agreed to in writing, + software distributed under the License is distributed on an + "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + KIND, either express or implied. See the License for the + specific language governing permissions and limitations + under the License. +--> + +# Connection Properties on Apache Arrow Flight SQL ODBC Driver + +## Setting ODBC Connection Properties + +ODBC connection parameters can be set in a connection string or defined in a DSN inside your system's odbc.ini. Review Comment: This implies DSNs are defined in the system's `odbc.ini`, but on Windows DSNs are typically stored via the ODBC Data Source Administrator (registry), not `odbc.ini`. Consider rephrasing to clarify the OS-specific location (e.g., `odbc.ini` on macOS/Linux vs ODBC Data Source Administrator/registry on Windows), or scope this document explicitly to Unix-like systems. ########## cpp/src/arrow/flight/sql/odbc/connection-options.md: ########## @@ -0,0 +1,64 @@ +<!--- + Licensed to the Apache Software Foundation (ASF) under one + or more contributor license agreements. See the NOTICE file + distributed with this work for additional information + regarding copyright ownership. The ASF licenses this file + to you under the Apache License, Version 2.0 (the + "License"); you may not use this file except in compliance + with the License. You may obtain a copy of the License at + + http://www.apache.org/licenses/LICENSE-2.0 + + Unless required by applicable law or agreed to in writing, + software distributed under the License is distributed on an + "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + KIND, either express or implied. See the License for the + specific language governing permissions and limitations + under the License. +--> + +# Connection Properties on Apache Arrow Flight SQL ODBC Driver + +## Setting ODBC Connection Properties + +ODBC connection parameters can be set in a connection string or defined in a DSN inside your system's odbc.ini. + +The following sample connection string and sample DSN are two equivalent ways to connect to Arrow. + +### Sample Connection String +``` +"driver={Apache Arrow Flight SQL ODBC Driver};host=127.0.0.1;port=12345;uid=sample_user;pwd=sample_password;useEncryption=false;useWideChar=true;" +``` + +### Sample DSN +``` +[Apache Arrow Flight SQL] +driver = Apache Arrow Flight SQL ODBC Driver +host = 127.0.0.1 +port = 12345 +uid = sample_user +pwd = sample_password +useEncryption = false +useWideChar = true +``` + +### Driver Connection Options +| Option | Description | Default | +|--------|-------------|---------------| +| `driver` | Required: the driver for this ODBC driver. | Apache Arrow Flight SQL | Review Comment: In the connection options table, the default/expected value for `driver` is listed as "Apache Arrow Flight SQL", but the sample connection string/DSN and registration scripts use "Apache Arrow Flight SQL ODBC Driver" as the driver name. Please update the default/required value (and ideally format it consistently) so users copy the correct installed driver name. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
