Copilot commented on code in PR #49851: URL: https://github.com/apache/arrow/pull/49851#discussion_r3175390049
########## cpp/src/arrow/flight/sql/odbc/README.md: ########## @@ -129,3 +148,4 @@ After ODBC has been registered, you can run the ODBC tests. It is recommended to - Conversion from timestamp data type with specified time zone value to strings is not supported at the moment. This doesn't impact driver's usage of retrieving timestamp data from Power BI on Windows, and Excel on macOS and Windows. See GH-47504 for more context. - Conversion from strings to big int data type has a limit range of -9007199254740992 to 9007199254740992. +- On Linux, `isql` commands `tables` and `columns` don’t work due to GH-49702. Users are not blocked from fetching data tables. Review Comment: Use an ASCII apostrophe for consistency with the rest of this document and to avoid copy/paste/search issues in some terminals/editors. ########## cpp/src/arrow/flight/sql/odbc/connection-options.md: ########## @@ -0,0 +1,64 @@ +<!--- + Licensed to the Apache Software Foundation (ASF) under one + or more contributor license agreements. See the NOTICE file + distributed with this work for additional information + regarding copyright ownership. The ASF licenses this file + to you under the Apache License, Version 2.0 (the + "License"); you may not use this file except in compliance + with the License. You may obtain a copy of the License at + + http://www.apache.org/licenses/LICENSE-2.0 + + Unless required by applicable law or agreed to in writing, + software distributed under the License is distributed on an + "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + KIND, either express or implied. See the License for the + specific language governing permissions and limitations + under the License. +--> + +# Connection Properties on Apache Arrow Flight SQL ODBC Driver + +## Setting ODBC Connection Properties + +ODBC connection parameters can be set in a connection string or defined in a DSN. On macOS and Linux, DSNs are typically defined in your system's `odbc.ini`. On Windows they are typically configured with the ODBC Data Source Administrator. + +The following sample connection string and sample DSN are two equivalent ways to connect to Arrow. + +### Sample Connection String +``` +"driver={Apache Arrow Flight SQL ODBC Driver};host=127.0.0.1;port=12345;uid=sample_user;pwd=sample_password;useEncryption=false;useWideChar=true;" Review Comment: The sample connection string is shown wrapped in double quotes, which can be mistaken as part of the literal connection string when copy/pasting into tools like `isql`/Power BI/Excel (most examples in this repo omit the surrounding quotes). Consider removing the outer quotes, or explicitly stating they’re only present to show a string literal. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
