lxy714433989 commented on code in PR #4272: URL: https://github.com/apache/arrow-adbc/pull/4272#discussion_r3167068970
########## java/driver/flight-sql/src/main/java/org/apache/arrow/adbc/driver/flightsql/FlightSqlOAuthTokenProvider.java: ########## Review Comment: Thanks for the suggestions. I’d prefer to keep this in the pure Java Flight SQL driver instead of relying on the Go driver through JNI, since JNI would introduce native dependencies and additional deployment complexity for Java users. For the OAuth2 implementation, I agree that we should use an existing library rather than hand-roll the protocol details. I noticed that Arrow Java already uses Nimbus OAuth2 SDK, so I think Nimbus would be a good fit for Java ADBC as well. I’ll update the PR accordingly. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
