lxy714433989 commented on code in PR #4272:
URL: https://github.com/apache/arrow-adbc/pull/4272#discussion_r3168313802


##########
java/driver/flight-sql/src/main/java/org/apache/arrow/adbc/driver/flightsql/FlightSqlOAuthTokenProvider.java:
##########


Review Comment:
   That makes sense. Since ADBC currently depends on Arrow Java 18.3.0 and the 
Arrow Java OAuth classes are not available in that version yet, directly 
reusing the JDBC implementation would require bumping the Arrow Java dependency.
   
   Would you prefer that I refactor the ADBC implementation in this PR to more 
closely mirror the Arrow Java JDBC OAuth structure, or should we wait until 
ADBC updates to an Arrow Java version that includes those OAuth classes and 
then reuse the implementation ?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to