Reranko05 commented on PR #49900: URL: https://github.com/apache/arrow/pull/49900#issuecomment-4352188713
Quick question regarding test expectations: With this change, `Engine::AddGlobalMappingForFunc` now skips registering functions that are not in `used_functions_` (except internal ones). This causes `TestLLVMGenerator.VerifyPCFunctions` and `VerifyExtendedCFunctions` to fail, as they currently expect all functions from the registry to be present in the module. With selective mapping, the expected behavior would be that only used functions (plus required internal helpers) are registered. Would you prefer updating these tests to validate only the functions explicitly passed via `used_functions`, rather than the entire registry? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
