Reranko05 commented on PR #49900: URL: https://github.com/apache/arrow/pull/49900#issuecomment-4360283874
Following up on this — after looking into it more, I think we should preserve the existing test expectations. The current tests validate the default Engine initialization behavior, which registers all functions, and that should remain unchanged. The intended behavior of this PR is: - `Engine::Init()` → unchanged (full mapping, used by tests and existing paths) - `Engine::Init(used_functions)` → selective mapping (used after expression decomposition) So selective mapping should only apply to the LLVMGenerator path, and should not affect existing tests. I'll ensure the implementation keeps this separation so that tests continue to pass without modification. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
