amoeba commented on code in PR #4303:
URL: https://github.com/apache/arrow-adbc/pull/4303#discussion_r3197414364
##########
.github/workflows/packaging.yml:
##########
@@ -1031,8 +1039,6 @@ jobs:
# TODO(https://github.com/apache/arrow-adbc/issues/4269): remove
cmd.exe usage
shell: cmd # zizmor: ignore[misfeature]
run: |
- where python.exe
- CALL "C:\Program Files\Microsoft Visual
Studio\2022\Community\VC\Auxiliary\Build\vcvars64.bat"
Review Comment:
Does this all really still work after removing this?
##########
ci/scripts/python_wheel_windows_build.bat:
##########
@@ -23,11 +23,13 @@ set build_dir=%2
echo "=== (%PYTHON_VERSION%) Building ADBC libpq driver ==="
set CMAKE_BUILD_TYPE=RelWithDebInfo
-set CMAKE_GENERATOR=Visual Studio 17 2022
+set CMAKE_GENERATOR=Visual Studio 18 2026
set CMAKE_GENERATOR_PLATFORM=x64
set CMAKE_UNITY_BUILD=ON
set VCPKG_FEATURE_FLAGS=-manifests
-set VCPKG_TARGET_TRIPLET=x64-windows-static
+set VCPKG_TARGET_TRIPLET=x64-windows-static-2019
+set VCPKG_DEFAULT_HOST_TRIPLET=x64-windows-static-2019
+set VCPKG_OVERLAY_TRIPLETS=%source_dir%\ci\vcpkg\triplets
Review Comment:
Why the custom target? A comment would be good (esp. as I don't know).
##########
ci/vcpkg/triplets/x64-windows-static-2019.cmake:
##########
@@ -0,0 +1,23 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+set(VCPKG_TARGET_ARCHITECTURE x64)
+set(VCPKG_CRT_LINKAGE static)
+set(VCPKG_LIBRARY_LINKAGE static)
+
+# Target VS2022
Review Comment:
```suggestion
# Target VS2019
```
This is what I expected this comment to be given
https://learn.microsoft.com/en-us/cpp/porting/binary-compat-2015-2017?view=msvc-170.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
