lidavidm commented on code in PR #4303: URL: https://github.com/apache/arrow-adbc/pull/4303#discussion_r3198212005
########## ci/scripts/python_wheel_windows_build.bat: ########## @@ -23,11 +23,13 @@ set build_dir=%2 echo "=== (%PYTHON_VERSION%) Building ADBC libpq driver ===" set CMAKE_BUILD_TYPE=RelWithDebInfo -set CMAKE_GENERATOR=Visual Studio 17 2022 +set CMAKE_GENERATOR=Visual Studio 18 2026 set CMAKE_GENERATOR_PLATFORM=x64 set CMAKE_UNITY_BUILD=ON set VCPKG_FEATURE_FLAGS=-manifests -set VCPKG_TARGET_TRIPLET=x64-windows-static +set VCPKG_TARGET_TRIPLET=x64-windows-static-2019 +set VCPKG_DEFAULT_HOST_TRIPLET=x64-windows-static-2019 +set VCPKG_OVERLAY_TRIPLETS=%source_dir%\ci\vcpkg\triplets Review Comment: I'm not actually sure we need to do this or that this actually has any effect. The runners only have 2026 installed, and vcpkg/cmake appear to fall back if it can't find the requested toolchain. Since everything is supposed to now be binary-compatible, I think just letting it use 2026 should be fine. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
