etseidl commented on PR #9831:
URL: https://github.com/apache/arrow-rs/pull/9831#issuecomment-4392289867
> might this still be a regression?
A bit, but only when compared to previously optimized code. Compared to
before @HippoBaro started, it's still quite nice. (comparing to #9654
f5d6dc3846c2321a4b97cb481ec6ae0907b08657)
```
list_primitive_sparse_99pct_null/bloom_filter 1.00 9.1±0.07ms
4.0 GB/sec 3.15 28.6±0.36ms 1305.5 MB/sec
list_primitive_sparse_99pct_null/cdc 1.00 18.7±0.44ms
1997.9 MB/sec
list_primitive_sparse_99pct_null/default 1.00 8.6±0.11ms
4.2 GB/sec 3.24 27.9±0.22ms 1337.2 MB/sec
list_primitive_sparse_99pct_null/parquet_2 1.00 8.7±0.21ms
4.2 GB/sec 3.29 28.5±1.21ms 1309.4 MB/sec
list_primitive_sparse_99pct_null/zstd 1.00 10.2±0.07ms
3.6 GB/sec 2.92 29.7±0.28ms 1257.0 MB/sec
list_primitive_sparse_99pct_null/zstd_parquet_2 1.00 8.7±0.05ms
4.2 GB/sec 3.23 28.2±0.30ms 1324.3 MB/sec
```
FWIW, the sparse regression isn't as bad on my WS
```
group 9831-2
main3
----- ------
-----
list_primitive/bloom_filter 1.00 284.4±1.73ms
1917.3 MB/sec 1.04 295.5±1.94ms 1845.3 MB/sec
list_primitive/cdc 1.00 300.8±6.25ms
1813.2 MB/sec 1.02 308.2±6.27ms 1769.8 MB/sec
list_primitive/default 1.00 224.9±1.85ms
2.4 GB/sec 1.04 234.6±3.39ms 2.3 GB/sec
list_primitive/parquet_2 1.00 235.3±5.39ms
2.3 GB/sec 1.06 249.0±5.09ms 2.1 GB/sec
list_primitive/zstd 1.00 371.7±3.83ms
1467.0 MB/sec 1.02 379.9±3.56ms 1435.7 MB/sec
list_primitive/zstd_parquet_2 1.00 366.4±1.82ms
1488.5 MB/sec 1.02 372.1±3.90ms 1465.6 MB/sec
list_primitive_non_null/bloom_filter 1.00 344.6±3.78ms
1579.5 MB/sec 1.02 352.3±7.27ms 1544.9 MB/sec
list_primitive_non_null/cdc 1.00 358.6±5.60ms
1517.7 MB/sec 1.01 360.6±4.80ms 1509.1 MB/sec
list_primitive_non_null/default 1.00 250.1±3.05ms
2.1 GB/sec 1.04 259.7±9.49ms 2.0 GB/sec
list_primitive_non_null/parquet_2 1.00 269.9±8.56ms
2016.7 MB/sec 1.00 270.0±7.87ms 2015.7 MB/sec
list_primitive_non_null/zstd 1.01 496.6±7.86ms
1096.0 MB/sec 1.00 492.2±2.43ms 1105.7 MB/sec
list_primitive_non_null/zstd_parquet_2 1.00 485.6±2.63ms
1120.8 MB/sec 1.01 490.2±1.64ms 1110.4 MB/sec
list_primitive_sparse_99pct_null/bloom_filter 1.02 9.1±0.07ms
4.0 GB/sec 1.00 8.9±0.08ms 4.1 GB/sec
list_primitive_sparse_99pct_null/cdc 1.07 18.7±0.44ms
1997.9 MB/sec 1.00 17.4±0.11ms 2.1 GB/sec
list_primitive_sparse_99pct_null/default 1.02 8.6±0.11ms
4.2 GB/sec 1.00 8.5±0.10ms 4.3 GB/sec
list_primitive_sparse_99pct_null/parquet_2 1.05 8.7±0.21ms
4.2 GB/sec 1.00 8.3±0.06ms 4.4 GB/sec
list_primitive_sparse_99pct_null/zstd 1.01 10.2±0.07ms
3.6 GB/sec 1.00 10.1±0.09ms 3.6 GB/sec
list_primitive_sparse_99pct_null/zstd_parquet_2 1.02 8.7±0.05ms
4.2 GB/sec 1.00 8.5±0.08ms 4.3 GB/sec
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
