HippoBaro commented on PR #9831: URL: https://github.com/apache/arrow-rs/pull/9831#issuecomment-4393457402
Thank you @etseidl, @alamb, and @Dandandan 💯 After trying a few alternatives to reduce the cost of the extra level representation variants, I think the remaining overhead in the `Materialized` path is the tradeoff for improving the `Absent` and `Uniform` cases. At the end of the day, we are making a tradeoff here. > A bit, but only when compared to previously optimized code. Compared to before @HippoBaro started, it's still quite nice. (comparing to https://github.com/apache/arrow-rs/pull/9654 https://github.com/apache/arrow-rs/commit/f5d6dc3846c2321a4b97cb481ec6ae0907b08657) I think that's fair. This PR is part of a larger series that, taken together, improves runtime across most writer benchmarks. I rebased the PR against `main` and worked through @alamb's feedback. I also added the builder pattern suggested [here](https://github.com/apache/arrow-rs/pull/9831#discussion_r3173434217) in 4d0f400. It's super neat! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
