james-rms opened a new pull request, #713:
URL: https://github.com/apache/arrow-rs-object-store/pull/713
# Which issue does this PR close?
<!--
We generally require a GitHub issue to be filed for all bug fixes and
enhancements and this helps us generate change logs for our releases. You can
link an issue to this PR using the GitHub syntax. For example `Closes #123`
indicates that this PR will close issue #123.
-->
Closes #712
The bug is explained in the PR description, can create an issue for
completeness if required.
# Rationale for this change
On `main`, `GoogleCloudStorage::copy(src, dst)` fails with
`Error::AlreadyExists` if `dst` is the path to an existing object. This is the
wrong default behavior - CopyMode defaults to Overwrite, not Create. This
happens because of a bug in `GoogleCloudStorage::copy_opts`, where
CopyMode::Overwrite gets mapped to `if_not_exists = true` instead of `false`.
This PR fixes and moves the boolean mapping closest to where it gets used,
to minimise confusion.
# What changes are included in this PR?
<!--
There is no need to duplicate the description in the issue here but it is
sometimes worth providing a summary of the individual changes in this PR.
-->
# Are there any user-facing changes?
Yes. Anyone using GoogleCloudStorage::copy today who is relying on the
incorrect behavior will see objects getting overwritten instead of an error.
<!--
If there are user-facing changes then we may require documentation to be
updated before approving the PR.
-->
<!---
If there are any breaking changes to public APIs, please call them out.
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
