RobertLD commented on PR #49771: URL: https://github.com/apache/arrow/pull/49771#issuecomment-4398896437
I’ll circle back in a day or two and apply these suggestions. Thanks for the feedback On Thu, May 7, 2026 at 09:45 David Li ***@***.***> wrote: > ***@***.**** commented on this pull request. > ------------------------------ > > In cpp/src/arrow/ipc/message.cc > <https://github.com/apache/arrow/pull/49771#discussion_r3201879954>: > > > @@ -565,6 +565,17 @@ Status DecodeMessage(MessageDecoder* decoder, io::InputStream* file) { > auto metadata_length = decoder->next_required_size(); > ARROW_ASSIGN_OR_RAISE(auto metadata, file->Read(metadata_length)); > if (metadata->size() != metadata_length) { > + // The first sizeof(int32_t) bytes of the Arrow file magic ("ARRO") may have been > + // misread as metadata_length. Check if the remaining bytes complete the magic. > > Yeah, a gigabyte of *metadata* raises flags anyways > > — > Reply to this email directly, view it on GitHub > <https://github.com/apache/arrow/pull/49771#discussion_r3201879954>, or > unsubscribe > <https://github.com/notifications/unsubscribe-auth/AHGZJYRWPFX5H5YEX4XHAM34ZSHO3AVCNFSM6AAAAACX3RU3WGVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHM2DENBUGQ4TKMZQGU> > . > You are receiving this because you were mentioned.Message ID: > ***@***.***> > -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
