SAY-5 commented on PR #49832: URL: https://github.com/apache/arrow/pull/49832#issuecomment-4416430856
Diagnosis: the new precision check in `DecimalFromString` rejects strings whose significant-digit count exceeds the target type's max precision. Existing `arrow-array`, `arrow-json`, and `arrow-s3fs` tests pass strings with 77 significant digits (e.g. for decimal256 = max 76) and were previously relying on the silent `ShiftAndAdd` overflow returning some value. The check fires correctly per the issue, but the test fixtures need updating to either: 1. trim trailing precision so they fit kMaxPrecision exactly, or 2. assert `Status::Invalid` instead of `ValueOrDie`. Affected test files (from CI logs): `arrow-array-test`, `arrow-json-test`, `arrow-s3fs-test`. I'd prefer to leave that test surgery for a maintainer who knows which assertions reflect intended behaviour vs. accidental reliance on overflow. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
