pitrou commented on PR #49832: URL: https://github.com/apache/arrow/pull/49832#issuecomment-4429438567
> Existing `arrow-array`, `arrow-json`, and `arrow-s3fs` tests pass strings with 77 significant digits (e.g. for decimal256 = max 76) and were previously relying on the silent `ShiftAndAdd` overflow returning some value. You mean `arrow-utility-test` not `arrow-s3fs-test`, right? In any case, I think these tests need to be fixed not to overflow the allowable precision. However, one of the tests is simply testing the error message. We should try to make the error messages consistent there to minimize disruption. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
