HuaHuaY commented on code in PR #50008:
URL: https://github.com/apache/arrow/pull/50008#discussion_r3281169773
##########
cpp/src/parquet/bloom_filter_writer.cc:
##########
@@ -185,8 +185,21 @@ class BloomFilterBuilderImpl : public BloomFilterBuilder {
const WriterProperties* properties_;
bool finished_ = false;
- using RowGroupBloomFilters =
- std::map</*column_id=*/int32_t, std::shared_ptr<BloomFilter>>;
+ struct RowGroupBloomFilters {
+ RowGroupBloomFilters() = default;
+ RowGroupBloomFilters(RowGroupBloomFilters&&) noexcept = default;
Review Comment:
I need these to prevent MSVC from attempting to instantiate the copy
constructor. See https://github.com/microsoft/STL/issues/5552 and
https://github.com/microsoft/STL/issues/5084.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
