HuaHuaY commented on code in PR #50008:
URL: https://github.com/apache/arrow/pull/50008#discussion_r3322936343
##########
cpp/src/parquet/bloom_filter.h:
##########
@@ -243,7 +243,7 @@ class PARQUET_EXPORT BlockSplitBloomFilter : public
BloomFilter {
/// @param fpp The false positive probability.
/// @return it always return a value between kMinimumBloomFilterBytes * 8 and
/// kMaximumBloomFilterBytes * 8, and the return value is always a power of
16
- static uint32_t OptimalNumOfBits(uint32_t ndv, double fpp) {
+ static uint32_t OptimalNumOfBits(uint64_t ndv, double fpp) {
Review Comment:
Because there are many `uint32_t` needed to be modified, so I think we have
to do this in another PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
