albertlockett commented on code in PR #9776:
URL: https://github.com/apache/arrow-rs/pull/9776#discussion_r3326182353
##########
arrow-ipc/src/reader.rs:
##########
@@ -781,24 +781,13 @@ fn read_dictionary_impl(
Ok(())
}
-/// Updates the `dictionaries_by_id` with the provided dictionary values and
id.
-///
-/// # Errors
-/// - If `is_delta` is true and there is no existing dictionary for the given
-/// `dict_id`
-/// - If `is_delta` is true and the concatenation of the existing and new
-/// dictionary fails. This usually signals a type mismatch between the old
and
-/// new values.
fn update_dictionaries(
dictionaries_by_id: &mut HashMap<i64, ArrayRef>,
is_delta: bool,
dict_id: i64,
dict_values: ArrayRef,
) -> Result<(), ArrowError> {
if !is_delta {
- // We don't currently record the isOrdered field. This could be general
- // attributes of arrays.
- // Add (possibly multiple) array refs to the dictionaries array.
dictionaries_by_id.insert(dict_id, dict_values.clone());
return Ok(());
Review Comment:
Why remove the comments from this?
##########
arrow-ipc/src/writer.rs:
##########
@@ -1467,6 +1467,7 @@ impl<W: Write> StreamWriter<W> {
}
write_continuation(&mut self.writer, &self.write_options, 0)?;
+ self.writer.flush()?;
Review Comment:
why this change?
##########
arrow-ipc/src/reader.rs:
##########
@@ -1070,7 +1134,7 @@ impl FileDecoder {
/// Read the RecordBatch with the given block and data buffer
pub fn read_record_batch(
- &self,
+ &mut self,
block: &Block,
buf: &Buffer,
) -> Result<Option<RecordBatch>, ArrowError> {
Review Comment:
This is unfortunately a breaking change to the public API. I'd prefer if we
could avoid this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
