pchintar commented on PR #9776: URL: https://github.com/apache/arrow-rs/pull/9776#issuecomment-4631295108
@albertlockett Thnx a lot for taking the time to review this so carefully. I spent some time re-checking this against the current code and I agree that this PR is not the right shape to move forward with. My optimization is only clearly attractive in a fairly narrow IPC-file case, while the current patch changes too much around the decoder path and makes the behavior harder to reason about than I’m comfortable with. I also don’t currently have a smaller version that I can justify confidently without risking subtle dictionary-ordering/decoder-state issues, so I’m going to close this PR rather than keep it open in a stale or speculative state. Thanks again for the detailed feedback — it helped me clarify the right boundary for this problem. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
