theirix opened a new pull request, #10042: URL: https://github.com/apache/arrow-rs/pull/10042
# Which issue does this PR close? <!-- We generally require a GitHub issue to be filed for all bug fixes and enhancements and this helps us generate change logs for our releases. You can link an issue to this PR using the GitHub syntax. --> - Closes #10033. # Rationale for this change Related to #22297, where using `FixedSizeBinary(-N)` caused failures. It will fail with a different error, but still panic. It could be a good idea to introduce `try_new_null` to carry an error gracefully - thoughts? # What changes are included in this PR? - Return a `Result` on negative byte width when possible - Panic explicitly with a proper error message otherwise - Avoid silent overflow with a direct `len as usize` cast # Are these changes tested? - Tests are passing # Are there any user-facing changes? No -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
