theirix commented on code in PR #10042:
URL: https://github.com/apache/arrow-rs/pull/10042#discussion_r3337145228


##########
arrow-schema/src/datatype_parse.rs:
##########
@@ -375,6 +375,12 @@ impl<'a> Parser<'a> {
     fn parse_fixed_size_binary(&mut self) -> ArrowResult<DataType> {
         self.expect_token(Token::LParen)?;
         let length = self.parse_i32("FixedSizeBinary")?;
+        if length < 0 {

Review Comment:
   The format doesn't tell anything about it. The C++ implementation [allows 
zero-width 
buffer](https://github.com/apache/arrow/blob/e2b44378edf0ccceda07e8a6823890bd4ecc1952/cpp/src/arrow/type.cc#L1117).
 Fixed an error message



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to