alamb commented on code in PR #10031: URL: https://github.com/apache/arrow-rs/pull/10031#discussion_r3342748198
########## arrow-flight/Cargo.toml: ########## @@ -105,3 +106,22 @@ required-features = ["flight-sql", "tls-ring"] name = "flight_sql_client_cli" path = "tests/flight_sql_client_cli.rs" required-features = ["cli", "flight-sql", "tls-ring"] + +[profile.bench] Review Comment: Normally we just use the release profile for benchmarking - is there any reason to add a `bench` profile target too? ########## arrow-flight/benchmarks/common/mod.rs: ########## @@ -0,0 +1,146 @@ +// Licensed to the Apache Software Foundation (ASF) under one Review Comment: yes please -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
