alamb commented on code in PR #10031:
URL: https://github.com/apache/arrow-rs/pull/10031#discussion_r3343816264
##########
arrow-flight/benches/common/mod.rs:
##########
@@ -0,0 +1,153 @@
+/ Licensed to the Apache Software Foundation (ASF) under one
Review Comment:
This doesn't compile for me:
```shell
Compiling arrow-flight v58.3.0
(/Users/andrewlamb/Software/arrow-rs2/arrow-flight)
error: expected item, found `/`
--> arrow-flight/benches/common/mod.rs:1:1
|
1 | / Licensed to the Apache Software Foundation (ASF) under one
| ^ expected item
|
= note: for a full list of items that can appear in modules, see
<https://doc.rust-lang.org/reference/items.html>
error[E0282]: type annotations needed for `&_`
--> arrow-flight/benches/flight_encode.rs:53:52
|
53 | g.bench_with_input(id, &batch, |b, batch| {
| ^^^^^
54 | b.to_async(&rt)
55 | .iter(|| send(channel.clone(), batch.clone()));
| ----- type
must be known at this point
|
help: consider giving this closure parameter an explicit type, where the
placeholders `_` are specified
|
53 | g.bench_with_input(id, &batch, |b, batch: &I| {
| ++++
For more information about this error, try `rustc --explain E0282`.
error: could not compile `arrow-flight` (bench "flight_encode") due to 2
previous errors
```
##########
arrow-flight/benches/common/mod.rs:
##########
@@ -0,0 +1,153 @@
+/ Licensed to the Apache Software Foundation (ASF) under one
Review Comment:
This doesn't compile for me:
```shell
cargo bench --bench flight_encode
```
```shell
Compiling arrow-flight v58.3.0
(/Users/andrewlamb/Software/arrow-rs2/arrow-flight)
error: expected item, found `/`
--> arrow-flight/benches/common/mod.rs:1:1
|
1 | / Licensed to the Apache Software Foundation (ASF) under one
| ^ expected item
|
= note: for a full list of items that can appear in modules, see
<https://doc.rust-lang.org/reference/items.html>
error[E0282]: type annotations needed for `&_`
--> arrow-flight/benches/flight_encode.rs:53:52
|
53 | g.bench_with_input(id, &batch, |b, batch| {
| ^^^^^
54 | b.to_async(&rt)
55 | .iter(|| send(channel.clone(), batch.clone()));
| ----- type
must be known at this point
|
help: consider giving this closure parameter an explicit type, where the
placeholders `_` are specified
|
53 | g.bench_with_input(id, &batch, |b, batch: &I| {
| ++++
For more information about this error, try `rustc --explain E0282`.
error: could not compile `arrow-flight` (bench "flight_encode") due to 2
previous errors
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
