cyb70289 commented on a change in pull request #9758:
URL: https://github.com/apache/arrow/pull/9758#discussion_r629837991
##########
File path: cpp/src/arrow/compute/kernels/aggregate_basic.cc
##########
@@ -75,48 +75,55 @@ struct CountImpl : public ScalarAggregator {
Status Finalize(KernelContext* ctx, Datum* out) override {
const auto& state = checked_cast<const CountImpl&>(*ctx->state());
- switch (state.options.count_mode) {
- case CountOptions::COUNT_NON_NULL:
- *out = Datum(state.non_nulls);
- break;
- case CountOptions::COUNT_NULL:
- *out = Datum(state.nulls);
- break;
- default:
- return Status::Invalid("Unknown CountOptions encountered");
+ if (state.options.skip_nulls) {
+ *out = Datum(state.non_nulls);
+ } else {
+ *out = Datum(state.nulls);
Review comment:
I prefer `count(list, skip_nulls=False) == length`.
User will have to call `count(list, skip_nulls=False) - count(list,
skip_nulls=True)` to get null count. Given count is such a trivial operation,
looks it's not a big problem. @jorisvandenbossche
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
