cyb70289 commented on a change in pull request #9758:
URL: https://github.com/apache/arrow/pull/9758#discussion_r629950742
##########
File path: cpp/src/arrow/compute/kernels/aggregate_basic.cc
##########
@@ -75,48 +75,55 @@ struct CountImpl : public ScalarAggregator {
Status Finalize(KernelContext* ctx, Datum* out) override {
const auto& state = checked_cast<const CountImpl&>(*ctx->state());
- switch (state.options.count_mode) {
- case CountOptions::COUNT_NON_NULL:
- *out = Datum(state.non_nulls);
- break;
- case CountOptions::COUNT_NULL:
- *out = Datum(state.nulls);
- break;
- default:
- return Status::Invalid("Unknown CountOptions encountered");
+ if (state.options.skip_nulls) {
+ *out = Datum(state.non_nulls);
+ } else {
+ *out = Datum(state.nulls);
Review comment:
Yes. But for current kernel, you have to call it twice if you want the
array length. So looks fair.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
