Copilot commented on code in PR #50082:
URL: https://github.com/apache/arrow/pull/50082#discussion_r3350019467
##########
ci/docker/python-free-threaded-wheel-windows-test-vs2022.dockerfile:
##########
@@ -24,11 +24,10 @@ ARG base
# hadolint ignore=DL3006
FROM ${base}
-ARG python=3.13
+ARG python=3.14
# hadolint ignore=SC1072
-RUN (if "%python%"=="3.13" setx PYTHON_VERSION "3.13.1") & \
- (if "%python%"=="3.14" setx PYTHON_VERSION "3.14.0")
+RUN (if "%python%"=="3.14" setx PYTHON_VERSION "3.14.5")
Review Comment:
This Windows free-threaded wheel test image Dockerfile was modified (Python
version / dependency install behavior), but
`PYTHON_WHEEL_WINDOWS_TEST_IMAGE_REVISION` in `.env` also needs to be bumped so
CI rebuilds/pulls the updated image instead of reusing the previous cached tag
(per the note at the top of this file).
##########
ci/docker/python-free-threaded-wheel-windows-test-vs2022.dockerfile:
##########
@@ -24,11 +24,10 @@ ARG base
# hadolint ignore=DL3006
FROM ${base}
-ARG python=3.13
+ARG python=3.14
# hadolint ignore=SC1072
-RUN (if "%python%"=="3.13" setx PYTHON_VERSION "3.13.1") & \
- (if "%python%"=="3.14" setx PYTHON_VERSION "3.14.0")
+RUN (if "%python%"=="3.14" setx PYTHON_VERSION "3.14.5")
Review Comment:
The `python` build-arg is still configurable, but this `RUN` step only sets
`PYTHON_VERSION` when `%python%` is `3.14`. If a different `--build-arg
python=...` is passed (even accidentally), the build will later fail with a
confusing download URL because `PYTHON_VERSION` is unset. Add an explicit
failure for unsupported versions (or remove the arg if only 3.14 is supported).
##########
ci/docker/python-free-threaded-wheel-musllinux-test-unittests.dockerfile:
##########
@@ -37,8 +37,7 @@ RUN apk update && \
# See available releases at:
https://github.com/astral-sh/python-build-standalone/releases
RUN set -e; \
case "${python_version}" in \
- 3.13) python_patch_version="3.13.9";; \
- 3.14) python_patch_version="3.14.0";; \
+ 3.14) python_patch_version="3.14.5";; \
esac && \
Review Comment:
This `case` statement sets `python_patch_version` only for 3.14. If
`python_version` is ever passed as an unexpected value, the download URL will
be malformed and fail later. Add an explicit default branch that errors out
early with a clear message.
##########
ci/docker/python-free-threaded-wheel-musllinux-test-imports.dockerfile:
##########
@@ -35,8 +35,7 @@ RUN apk update && \
# See available releases at:
https://github.com/astral-sh/python-build-standalone/releases
RUN set -e; \
case "${python_version}" in \
- 3.13) python_patch_version="3.13.9";; \
- 3.14) python_patch_version="3.14.0";; \
+ 3.14) python_patch_version="3.14.5";; \
esac && \
Review Comment:
This `case` statement sets `python_patch_version` only for 3.14. If
`python_version` is ever passed as an unexpected value, the download URL will
be malformed and fail later. Add an explicit default branch that errors out
early with a clear message.
##########
ci/scripts/python_wheel_unix_test.sh:
##########
@@ -100,19 +100,10 @@ if [ "${CHECK_WHEEL_CONTENT}" == "ON" ]; then
--path "${source_dir}/python/repaired_wheels"
fi
-is_free_threaded() {
- python -c "import sysconfig; print('ON' if
sysconfig.get_config_var('Py_GIL_DISABLED') else 'OFF')"
-}
-
if [ "${CHECK_UNITTESTS}" == "ON" ]; then
# Install testing dependencies
- if [ "$(is_free_threaded)" = "ON" ] && [[ "${PYTHON:-}" == *"3.13"* ]]; then
- echo "Free-threaded Python 3.13 build detected"
- python -m pip install -U -r
"${source_dir}/python/requirements-wheel-test-3.13t.txt"
- else
- echo "Regular Python build detected"
- python -m pip install -U -r
"${source_dir}/python/requirements-wheel-test.txt"
- fi
+ echo "Regular Python build detected"
+ python -m pip install -U -r
"${source_dir}/python/requirements-wheel-test.txt"
Review Comment:
This log line is now misleading for free-threaded wheel tests: the script no
longer detects free-threaded builds but still prints "Regular Python build
detected". Use a neutral message (or reintroduce detection) so logs correctly
reflect what’s happening.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
