Copilot commented on code in PR #50082:
URL: https://github.com/apache/arrow/pull/50082#discussion_r3350497174
##########
ci/docker/python-free-threaded-wheel-windows-test-vs2022.dockerfile:
##########
@@ -24,11 +24,10 @@ ARG base
# hadolint ignore=DL3006
FROM ${base}
-ARG python=3.13
+ARG python=3.14
# hadolint ignore=SC1072
-RUN (if "%python%"=="3.13" setx PYTHON_VERSION "3.13.1") & \
- (if "%python%"=="3.14" setx PYTHON_VERSION "3.14.0")
+RUN (if "%python%"=="3.14" setx PYTHON_VERSION "3.14.5")
Review Comment:
This only sets PYTHON_VERSION when ARG python is exactly 3.14; if someone
overrides the build arg, the later PowerShell step will build a URL with an
empty version and fail with a confusing error. Consider failing fast with an
explicit unsupported-version branch (or set a default).
##########
ci/docker/python-free-threaded-wheel-musllinux-test-imports.dockerfile:
##########
@@ -35,8 +35,7 @@ RUN apk update && \
# See available releases at:
https://github.com/astral-sh/python-build-standalone/releases
RUN set -e; \
case "${python_version}" in \
- 3.13) python_patch_version="3.13.9";; \
- 3.14) python_patch_version="3.14.0";; \
+ 3.14) python_patch_version="3.14.5";; \
esac && \
Review Comment:
The case statement has no default branch; if python_version is ever set to
an unsupported value, python_patch_version will be empty and the download URL
will be malformed. Add a default case that errors out explicitly.
##########
ci/docker/python-free-threaded-wheel-musllinux-test-unittests.dockerfile:
##########
@@ -37,8 +37,7 @@ RUN apk update && \
# See available releases at:
https://github.com/astral-sh/python-build-standalone/releases
RUN set -e; \
case "${python_version}" in \
- 3.13) python_patch_version="3.13.9";; \
- 3.14) python_patch_version="3.14.0";; \
+ 3.14) python_patch_version="3.14.5";; \
esac && \
Review Comment:
The case statement has no default branch; if python_version is ever set to
an unsupported value, python_patch_version will be empty and the download URL
will be malformed. Add a default case that errors out explicitly.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
