alamb commented on PR #10015: URL: https://github.com/apache/arrow-rs/pull/10015#issuecomment-4633949934
> > I'm not completely sure what I think of [forcibly annotating all FLBA(16) as UUID]... let me chew on that and report back. But don't block on me I fail to report back by EOD tomorrow. Yeah, that was my initial concern too. It makes sense to me when going from Variant UUID --> Arrow (FixedLengthByteArray(16)) to annotate using UUID However, going from unannotated Arrow (FixedLengthByteArray(16)) --> Variant UUID seems like it may apply some semantic meaing to the FLBA that was not intended On the other hand, Variant doesn't seem to have any way to actually store a FLBA anyways so it wouldn't survive round trip anyways, so 🤷 > And injecting the UUID extension type is not worse than today, where we silently treat it as UUID. If this is the case, I am sold this PR is step forward > So it seems like this is a reasonable step forward for now. If we later decide we _really_ want the ability to blow up when somebody forgot to annotate their FLBA(16), we can always do the work to plumb field info through and tighten up the behavior. > > @alamb - how does that sound to you? 👍 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
