scovich commented on PR #10015: URL: https://github.com/apache/arrow-rs/pull/10015#issuecomment-4662512950
> > But how does that relate to `arrow_to_parquet_type`? If nobody calls `from_parts` along the way, then the type won't be injected. > > By that time `VariantArray` is already written using `from_parts` or canonicalized via `try_new`. Is it _always_ written that way? Or we just expect it's usually written that way? I don't have a good intuition of how easy it would be for a write path to bypass the other two paths that apply the fixup? If it's easy to accidentally bypass the other fixups, we should consider injecting another fixup to cover it, or filing an issue to do so as a follow-up. Otherwise, I think I'm good to merge but @alamb seemed to have some hesitation so I'll defer to him. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
