Rich-T-kid commented on PR #10044:
URL: https://github.com/apache/arrow-rs/pull/10044#issuecomment-4651953981
Replaced the (`arrow_data()`, `encoded_buffers()`, `is_direct()`) triple
threaded through `write_array_data()` with a single BufferSink passed by the
caller, eliminating every if is_direct { collect_encoded_buffers(...) } else {
write_buffer(...) } branch that was repeated at each buffer write site. All
path-specific logic is now encapsulated once in `encode_sink_buffer()`, which
write_array_data calls uniformly regardless of whether the output is headed for
an in-memory EncodedData or a direct stream write. About -400 LOC @gabotechs
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
