Rich-T-kid commented on PR #10044: URL: https://github.com/apache/arrow-rs/pull/10044#issuecomment-4644011061
The diff looks larger than it is due to `estimate_encoded_buffer_count()` (which estimates how many slots to pre-allocate for the buffer vector) and the if statements that determine whether `write_buffers()` or `collect_encoded_buffers()` is called based on whether a Writer was supplied. This avoids duplicating logic by reusing shared functionality across both code paths. @gabotechs could you take another look at this when you get a chance 🚀 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
