lidavidm commented on a change in pull request #10230:
URL: https://github.com/apache/arrow/pull/10230#discussion_r630423781
##########
File path: python/pyarrow/_dataset.pyx
##########
@@ -1747,8 +1749,15 @@ cdef class CsvFileFormat(FileFormat):
FileFormat.init(self, sp)
self.csv_format = <CCsvFileFormat*> sp.get()
- def make_write_options(self):
- raise NotImplemented("writing CSV datasets")
+ def make_write_options(self, WriteOptions options=None,
Review comment:
I could have it take **kwargs which get forwarded to csv.WriteOptions;
now that I look, that's what ParquetFileFormat does.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
