emkornfield commented on a change in pull request #10230:
URL: https://github.com/apache/arrow/pull/10230#discussion_r631166917
##########
File path: python/pyarrow/_csv.pyx
##########
@@ -946,15 +951,44 @@ def write_csv(data, output_file, write_options=None,
get_writer(output_file, &stream)
c_memory_pool = maybe_unbox_memory_pool(memory_pool)
+ c_write_options.io_context = CIOContext(c_memory_pool)
if isinstance(data, RecordBatch):
batch = pyarrow_unwrap_batch(data).get()
with nogil:
- check_status(WriteCSV(deref(batch), c_write_options, c_memory_pool,
- stream.get()))
+ check_status(WriteCSV(deref(batch), c_write_options, stream.get()))
elif isinstance(data, Table):
table = pyarrow_unwrap_table(data).get()
with nogil:
- check_status(WriteCSV(deref(table), c_write_options, c_memory_pool,
- stream.get()))
+ check_status(WriteCSV(deref(table), c_write_options, stream.get()))
else:
raise TypeError(f"Expected Table or RecordBatch, got '{type(data)}'")
+
+
+cdef class CsvWriter(_CRecordBatchWriter):
Review comment:
nit: as much as I appreciate Csv naming convention I think CSV is used
everywhere else?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
