HuaHuaY commented on code in PR #50157:
URL: https://github.com/apache/arrow/pull/50157#discussion_r3394239629
##########
cpp/src/parquet/metadata.cc:
##########
@@ -90,36 +90,111 @@ std::string ParquetVersionToString(ParquetVersion::type
ver) {
return "UNKNOWN";
}
+namespace {
+
+enum class StatsMinMaxMode {
+ // Ignore min/max fields because their ordering is unknown or unsupported.
+ kDiscard,
+ // Use legacy min/max fields for files without column orders.
+ kLegacy,
+ // Use min_value/max_value fields with the column's well-defined order.
+ kNormal,
+};
+
+inline StatsMinMaxMode GetStatsMinMaxMode(const ColumnDescriptor& descr) {
Review Comment:
I think `inline` is meaningless here. But there are many `inline` in this
file. We can remove them in a new PR in the future.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
